Bluetooth: Controller: Enable ISO support in the SDC #12508
Conversation
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
rugeGerritsen
force-pushed
the
enable_iso_support
branch
from
6f8f8b0
to
5256680
Compare
|
|
||
| #if defined(CONFIG_BT_CTLR_SYNC_ISO) | ||
| #define SDC_MEM_BIS_SINK \ | ||
| SDC_MEM_PER_BIG(CONFIG_BT_CTLR_SYNC_ISO_STREAM_COUNT) + \ |
There was a problem hiding this comment.
I'm currently trying to merge a fix to change this to CONFIG_BT_CTLR_SCAN_SYNC_ISO_SET
There was a problem hiding this comment.
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
rugeGerritsen
force-pushed
the
enable_iso_support
branch
from
5256680
to
e1303fa
Compare
rugeGerritsen
force-pushed
the
enable_iso_support
branch
from
e1303fa
to
275fdba
Compare
| (sdc_hci_cmd_le_remove_iso_data_path_t const *)cmd_params, | ||
| (sdc_hci_cmd_le_remove_iso_data_path_return_t *)event_out_params); | ||
|
|
||
| case SDC_HCI_OPCODE_CMD_LE_ISO_TEST_END: |
There was a problem hiding this comment.
we can do that in a separate PR, but should we consider ifdef-ing out the test commands?
There was a problem hiding this comment.
I agree. We could consider adding more ifdefs for both the ISO test commands and also the Create CIG/BIG Test commands, Read Link quality and others
| (sdc_hci_cmd_le_iso_test_end_t const *)cmd_params, | ||
| (sdc_hci_cmd_le_iso_test_end_return_t *)event_out_params); | ||
|
|
||
| case SDC_HCI_OPCODE_CMD_LE_SET_HOST_FEATURE: |
There was a problem hiding this comment.
Should this be in a CONFIG_BT_CTLR_SET_HOST_FEATURE ?
There was a problem hiding this comment.
should it also be outside the CONFIG_BT_CTLR_ISO, to be aligned with https://github.com/nrfconnect/sdk-nrf/pull/12508/files#diff-f5bf9d2614b19c06ca472417c8004daeae8125af4a59c8ec6983180c9ddae3daR560 ?
| @@ -40,6 +40,7 @@ static bool command_generates_command_complete_event(uint16_t hci_opcode) | |||
| { | |||
| switch (hci_opcode) { | |||
| case SDC_HCI_OPCODE_CMD_LC_DISCONNECT: | |||
| case SDC_HCI_OPCODE_CMD_CB_WRITE_CONN_ACCEPT_TIMEOUT: | |||
There was a problem hiding this comment.
The SDC_HCI_OPCODE_CMD_CB_WRITE_CONN_ACCEPT_TIMEOUT creates a command complete
rugeGerritsen
force-pushed
the
enable_iso_support
branch
from
275fdba
to
da24603
Compare
rugeGerritsen
force-pushed
the
enable_iso_support
branch
from
da24603
to
f1c2121
Compare
| (sdc_hci_cmd_le_iso_test_end_t const *)cmd_params, | ||
| (sdc_hci_cmd_le_iso_test_end_return_t *)event_out_params); | ||
|
|
||
| case SDC_HCI_OPCODE_CMD_LE_SET_HOST_FEATURE: |
There was a problem hiding this comment.
should it also be outside the CONFIG_BT_CTLR_ISO, to be aligned with https://github.com/nrfconnect/sdk-nrf/pull/12508/files#diff-f5bf9d2614b19c06ca472417c8004daeae8125af4a59c8ec6983180c9ddae3daR560 ?
rugeGerritsen
force-pushed
the
enable_iso_support
branch
from
f1c2121
to
241141b
Compare
| #if defined(CONFIG_BT_CTLR_ISO_TX_BUFFERS) | ||
| static int iso_handle(struct net_buf *acl) | ||
| { | ||
| LOG_DBG(""); |
There was a problem hiding this comment.
what's the point of this?
rugeGerritsen
force-pushed
the
enable_iso_support
branch
2 times, most recently
from
cd4866f
to
a8ee792
Compare
This commit enables the experimental ISO support in the SoftDevice Controller. See the changelog for more details. Signed-off-by: Rubin Gerritsen <[email protected]>
rugeGerritsen
force-pushed
the
enable_iso_support
branch
from
a8ee792
to
9f2240d
Compare
rugeGerritsen
removed
DNM
changelog-entry-required
This commit enables the experimental ISO support in the SoftDevice Controller. See the changelog for more details.